Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update precompressed tile documentation #390
Update precompressed tile documentation #390
Changes from 9 commits
b30f541
0a88a04
261c8f3
4616b72
5859e44
766bdeb
ede1cd8
9aa0a99
a0fbd39
d9cefd8
e57be72
add1e02
505cc2f
4d06960
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first read, this felt slightly redundant with the previous bullet point even though the message is different.
Also maybe this needs to be stated as in.
the input format must have precompressed tiles reading support and the output format must have precompressed tiles writing support
with a reference to the paragraph about the supported formatsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming additional formats get added to this list mid-term, https://bio-formats.readthedocs.io/en/latest/formats/index.html would probably the natural section to keep a reference of all readers/writers supporting precompressed tile reading/writing. If a developer page gets introduced about precompressed tile reading/writing, this would also be more natural as a link rather than adding a reference to a subsection of a command-line utility page.
Reviewing the few available options:
DynamicMetadataOptions
but could include additional reader/writer specificityThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to split into two pages - one under
/formats/
that has the high-level summary and list of supported readers/writers, and the original one under/users/comlinetools/
that's more bfconvert-specific. Open to other thoughts though if that doesn't make sense.