Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link #405

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix link #405

wants to merge 3 commits into from

Conversation

pwalczysko
Copy link
Member

Fixing today's failing build

Copy link
Member

@melissalinkert melissalinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-linkcheck/328/consoleText shows a failure on https://hcimage.com/....

Maybe worth updating all instances of http://hcimage.com to use https, both in src/main/resources/format-pages.txt and in the ignore list?

Copy link
Member

@melissalinkert melissalinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-linkcheck/331/ is looking better, but it looks like https://hcimage.com on line 2339 of format-pages.txt isn't being ignored - possibly because there isn't a trailing slash in the URL.

Note though that opening https://hcimage.com in a browser now works, and shows a valid certificate. It might be worth waiting until Monday to make further changes, as I'd kind of expect the next build to fix itself.

@melissalinkert
Copy link
Member

https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-linkcheck/332/ is fixed without any changes to this PR, so propose to remove the configuration change but keep the http -> https changes in the documentation.

@melissalinkert melissalinkert added this to the 8.1.0 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants