-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix, thumb nails are unsigned integers, and exceeded 2^31, so I changed their size to Long #4100
Conversation
added the code for getUsedFile added support for compress sldyz/npyz files
Fixed GetVoxelSize
thumb nails are unsigned integers, and exceeded 2^31, so I changed their size to Long
… 2^31 fixed more errors when trying to decode an integer value greater than 2^31
Added a comment
There were some large numbers (> 2^31) in the yaml metadata files which referred to the older sld format pointers in the file, and are not used in format 7 (sldy). These numbers anyway were read in as Integer and that generated an exception. I have tracked down several and changed them to Long. I have also added try/catch around the decoding of numbers from the yaml file, and that will produce warnings but will not kill the file load. If during testing you get any warnings in the console, please send them to me. |
Empty PR description. Please add a short summary of the PR scope and some testing instructions. |
5 similar comments
Empty PR description. Please add a short summary of the PR scope and some testing instructions. |
Empty PR description. Please add a short summary of the PR scope and some testing instructions. |
Empty PR description. Please add a short summary of the PR scope and some testing instructions. |
Empty PR description. Please add a short summary of the PR scope and some testing instructions. |
Empty PR description. Please add a short summary of the PR scope and some testing instructions. |
@nicolapapp This PR seems to have caused some failures in our nightly repository tests, https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-test-folder/lastFailedBuild/console It looks as though some files are now failing isThisType and not being recognised by the reader, and for others the physical pixel size seems to have changed:
|
…taStore Added code to import the ROI annotations and store them in the MetadataStore. tested ok in fiji by me and out slidebook project manager
@nicolapapp, there is a large number of code changes included here that seem to be greater than the original description of the PR (changing unsigned ints to long). Are all of these changes meant to be included? Do you have a description of what other functionality has changed and how we can best test it? |
@nicolapapp : in order to consider this pull request for inclusion, we will need answers to the questions in #4100 (comment). If we don't hear back from you within the next week, this pull request will be closed (but you are welcome to re-open it once the outstanding questions are answered). |
There were some large numbers (> 2^31) in the yaml metadata files which referred to the older sld format pointers in the file, and are not used in format 7 (sldy). These numbers anyway were read in as Integer and that generated an exception. I have tracked down several and changed them to Long. I have also added try/catch around the decoding of numbers from the yaml file, and that will produce warnings but will not kill the file load. If during testing you get any warnings in the console, please send them to me. |
Thanks @nicolapapp. I understand that is the intention of the first few commits here, but there are other changes (for example 0fd31bd) that are not related to large number handling. Could you please either remove those other changes, or summarize what they are and let us know how we can test them? |
Closing as noted above. @nicolapapp, feel free to re-open this pull request once the extra commits are removed, or the full set of changes is described along with appropriate test data. |
There were some large numbers (> 2^31) in the yaml metadata files which referred to the older sld format pointers in the file, and are not used in format 7 (sldy). These numbers anyway were read in as Integer and that generated an exception. I have tracked down several and changed them to Long. I have also added try/catch around the decoding of numbers from the yaml file, and that will produce warnings but will not kill the file load. If during testing you get any warnings in the console, please send them to me.