Add test for image names when resolutions are not flattened #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tened Some readers report noticeably different image names based on the resolution flattening setting. This allows an alternate image name to be configured, so that both sets of image names can be checked for regressions.
|
On the positive side, it looks like tests have been failing if and only if the format is multi-resolution which was the expectation. |
sbesson
reviewed
Nov 13, 2023
|
As discussed today with @melissalinkert and @joshmoore, I agree the latest state of this PR puts us in a nice compromise between:
Next step here is to update the configuration files for all pyramidal file formats and re-include this PR in the nightly CI builds |
sbesson
approved these changes
Jan 5, 2024
dgault
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases, the
Imagenames stored in aMetadataStorewill not depend onhasFlattenedResolutions(). For some pyramid formats (e.g. SVS, CZI), theImagenames are noticeably different.This updates the config file generation to add an
Alternate_Namerepresenting the unflattenedImagename, if the unflattenedImagename is different from the flattenedImagename for a particular series/resolution. The newtestUnflattenedImageNameschecks this value, and errors if the name provided by an unflattened reader does not match either configured name.I would expect this to cause test failures for SVS, CZI, and potentially others. I am happy for this to be excluded once at least test run has completed (so we know the scope of config changes required).