-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert RunTimeException when JPEGTurbo cannot be loaded #4115
Conversation
I'm completely fine with this approach for 7.1.0, but for a future release would it be worth something like:
That would be in the spirit of #4090 (fail before |
Yeah, that seems like a good approach that would meet the demands of the initial PR but without failing unnecessarily. I will look at getting it implemented as part of this PR. |
Testing on my arm64 machine:
Testing required running:
after each build, even though I had deleted turbojpeg:
🤷🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look reasonable to me, with the caveat that I am not set up to actually test functionality.
Reverts the changes from #4090
Fixes #4109
To test you should attempt to instance ImageReader reader = new ImageReader(); while using Apple Silicon. This should throw a RunTimeException even if the desired reader does not require JPEGTurbo.
I opted to revert the change rather than catch the exception in ImageReader as this would negate the original reason for adding the exception.