Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java 9+ warnings in formats-gpl component #4182

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

melissalinkert
Copy link
Member

Last planned PR that goes together with #4177, #4178, and #4179.

As with #4179, excluding for now so this doesn't risk a failing build leading up to 7.3.0. I wouldn't really expect test failures, but this does modify many readers.

@melissalinkert melissalinkert added this to the 8.0.0 milestone Apr 12, 2024
Copy link
Member

@dgault dgault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the code changes included here look goof from my perspective. The builds and tests have continued to pass with this PR included and local testing of multiple formats shows no regressions.

@dgault dgault merged commit bf2c462 into ome:develop Apr 30, 2024
18 checks passed
@dgault dgault modified the milestones: 8.0.0, 7.3.1 Jul 8, 2024
@melissalinkert melissalinkert deleted the gpl-warnings branch September 6, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants