Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bioformats2raw.layout #112
bioformats2raw.layout #112
Changes from 27 commits
d7c0556
8ee02d1
ee15455
c8e98e4
6403d88
890e8a2
b099281
2b67a36
31d34c3
3173303
d44a066
7574d22
ff5d7ec
e2119e5
4fcc045
57acc23
5eca169
cf4e04c
89c322d
3691437
499caee
c7582e5
399b70b
740a11b
1f91482
861227b
8e612ef
a0919be
5971927
88fd042
7b7c43f
106c301
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
will
here actually meanMUST
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm.... I think that's right, but what I was trying to get across is that "the next statement only holds when
"plate"
isn't defined". Is that the same thing as the MUST?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or more simply:
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what bothers me in the logic is that the "plate MUST take precedence" applies much higher, e.g. even if the XML exists. Let me try to break all the clauses apart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed this proposal for feedback, @melissalinkert:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Primary question from my side is if it's actually:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest version is definitely clearer, thank you. I think
Matching "series" metadata (as described next) SHOULD be provided
makes sense, but I don't have strong objections toMAY
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're unsure, I'll err on the side of the stricter
SHOULD
and then we can downgrade it later.