Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngff zarr 0.5 #284

Merged
merged 2 commits into from
Dec 11, 2024
Merged

ngff zarr 0.5 #284

merged 2 commits into from
Dec 11, 2024

Conversation

thewtex
Copy link
Contributor

@thewtex thewtex commented Dec 9, 2024

  • tools: note that File Reading/Writing tools also support conversion
  • rfc-2: note ngff-zarr implementation support

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Automated Review URLs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

@thewtex
Copy link
Contributor Author

thewtex commented Dec 9, 2024

Example validation: https://ome.github.io/ome-ngff-validator/?source=https://bafybeihtjs5tjn26jfcbhe65wrewgwvhlbeyqe2qztjiqjq5yz7ycmcclq.ipfs.w3s.link/

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example validation ...

Lovely! Makes my heart happy. (Now we just need an @ngffbot to pick up URLs and send them to the validator 😄)

I'll hold off on merging for any comments from @normanrz as the author. Personally I think this adds weight to the imminent 0.5 and so makes sense. Long-term, I think the strategy of needing or wanting to update the RFCs page with tools may become burdensome. (If so, I'd almost say we automate it via a little JSON in the repository that lets us autogenerate the tools/ page and the RFC support sections.)

@normanrz
Copy link
Contributor

I am ok with these changes. I agree with Josh that RFCs should essentially become frozen once accepted.

@joshmoore joshmoore merged commit 2f37b61 into ome:main Dec 11, 2024
10 checks passed
github-actions bot added a commit that referenced this pull request Dec 11, 2024
SHA: 2f37b61
Reason: push, by @joshmoore

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants