URLHandle: fall back to resetting stream if resetting to a mark fails #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgault
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
The logic here looks sensible and makes sense as a fallback. I have tried again to find a way to replicate the original exception seen in ome/bioformats#3918 but have been unable to do so. At very least this PR is an improvement on the existing behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ome/bioformats#3918
I believe this will help with the first problem in that issue:
as this will force the whole stream to be reinitialized if resetting to the marked position fails when seeking backwards. I don't have a good way to test this though, as I wasn't actually able to reproduce the original exception.