Fix Lurawave debug error being printed #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Thanks @CGDogan for the contribution, I was initially confused as I thought the reference had been cleaned up in #81 but after careful re-reading this was only removing the loci.formats.services.LuraWaveService wrapper. Since we also remove the OME codec in ome/ome-codecs#30, this also needs to be deleted
Assuming this passes the nightly OME CI builds, I agree we should get this released and included into the next Bio-Formats patch release to remove unnecessary debug statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been removed or was this kept intentionally? @sbesson #81