Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConfigArgParse #76

Closed
wants to merge 2 commits into from
Closed

Use ConfigArgParse #76

wants to merge 2 commits into from

Conversation

manics
Copy link
Member

@manics manics commented Jan 24, 2016

omego uses argparse classes directly, so will fail with the changes in ome/yaclifw#7

This PR makes ConfigArgParser mandatory, and also disables all support for environment variables.

Testing

You should be able to specify config values in an ini file (or yaml if PyYAML is installed). All config values should be at the top level (they are not split between subcommands, [section headings] are ignored). If specified the -c/--config file.ini argument must come before the subcommand.

E.g.

$ cat << EOF > config.ini 
branch=OMERO-DEV-latest
verbose=True
EOF

$ omego -c config.ini download py --skipunzip

is equivalent to

$ omego download py --skipunzip -v --branch OMERO-DEV-latest

Todo

  • Bump yaclifw version in requirements.txt and setup.py

Note this intentionally removes the ability to specify argument values using environment variables to reduce confusion (though ConfigArgParse could be configured to automatically read environment variables if desired).

See ome/yaclifw#7
@sbesson
Copy link
Member

sbesson commented Mar 20, 2020

Closing as this conflicts with several files and will need some work.

@sbesson sbesson closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants