Set logback dependency to 1.2.x #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bio-Formats 6.12.x which is a transitive dependency of this component ships slf4-api 1.7.x which is only supported up to 1.2.x While using logback 1.3.x is doable and Gradle will automatically select a higher version of slj4-api 2.x, this might cause problems for downstream components using different resolution mechanisms like Ivy or Maven
jburel
reviewed
Mar 10, 2023
There was a problem hiding this comment.
I have tested this PR using the GitHub action
see https://github.com/jburel/openmicroscopy/blob/rebuild/.github/workflows/source_build.yml
The build is green https://github.com/jburel/openmicroscopy/actions/runs/4386568826
I will check merge-ci for eventual side effects
|
Assuming no side-effect on the rest of the CI, is the plan to get this merged and released as 5.6.2 to fix the downstream build? |
|
Two failures in the CI builds using 6c02c0e:
|
|
https://github.com/jburel/openmicroscopy/actions/runs/4386568826/jobs/7712042429 is green with the latest commit |
jburel
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bio-Formats 6.12.x which is a transitive dependency of this component ships slf4-api 1.7.x which is only supported up to 1.2.x While using logback 1.3.x is doable and Gradle will automatically select a higher version of slj4-api 2.x, this might cause problems for downstream components using different resolution mechanisms like Ivy or Maven
Hopefully this is the solution for the build failures of ome/openmicroscopy#6341