Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 0.2: use nested chunks #59

Merged
merged 4 commits into from
Apr 24, 2021
Merged

Bump to 0.2: use nested chunks #59

merged 4 commits into from
Apr 24, 2021

Conversation

joshmoore
Copy link
Member

@will-moore
Copy link
Member

I don't know how long all the various version numbers will stay in sync, but for now it would be easier if there was a single VERSION variable to use in all these places so we don't miss one.

@will-moore
Copy link
Member

This PR seems to be causing directories in a Plate to be named with lowercase.
Also, the .zattrs and .zgroup have the . missing from their names:

E.g. $ omero zarr export Plate:251

Without this PR:

$ ls 251.zarr/
A	B	C

With this PR:

$ ls 251.zarr/
a	b	c	zattrs	zgroup

@joshmoore
Copy link
Member Author

@will-moore : it's unlikely I'll be getting to this PR today if you want to push any commits.

@will-moore
Copy link
Member

Ah, OK the naming of .zattrs .group is fixed by upgrading zarr to zarr-2.7.0.
But still seeing lowercase dir names...

@will-moore
Copy link
Member

will-moore commented Apr 9, 2021

@joshmoore joshmoore marked this pull request as ready for review April 24, 2021 09:31
@joshmoore joshmoore merged commit fdc1e32 into ome:master Apr 24, 2021
@joshmoore joshmoore deleted the nested branch April 24, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants