-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nginx version #1439
nginx version #1439
Conversation
Just a heads up, we will need to check the version installed in |
@jburel I think we install distribution packages/download from nginx website, version is provided by them, do we hardcode any versions? |
We don't hardcode version but in the case of postgres we had 9.3 dropped in our list and 9.3 is the version installed when using the distribution package on ubuntu |
typo: recommemded => recommended |
Adjustment made to ome/omero-install#94 to match changes in the doc. |
* - 1.9 | ||
- N/A | ||
- N/A | ||
- 14.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the Debian and Ubuntu versions here correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who can answer this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the problem which Ubuntu is being looked at? @aleksandra-tarkowska : what did you check against?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on the bottom of the table https://www.openmicroscopy.org/site/support/omero5.2-staging/sysadmins/version-requirements.html#nginx there are REF links, see there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I think I am not getting this table right, 1.9 in general should not be there, as it is develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to show 1.2 ? 1.4/1.6 is legacy version already and is the lowest installed by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that we have now installed 1.8 on all OS in omero-install
For Ubuntu14.04, the "default" version installed is 1.4
if we wish to support < 1.8 we will have to introduce a new parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aleksandra-tarkowska All the versions should be there; this table is firstly a list of the upstream releases of a project, and secondly showing our level of support for each version. For other components on this page, we have dropped older irrelevant releases, and for this component everything before 1.6 sounds fine. But having all the later ones there is necessary, and given that the latest Ubuntu LTS is using 1.9, it needs to be there as well.
Does this PR need further work (e.g. in light of https://trello.com/c/FXt1rXQl/1-scoping-team) or is it ready to be relisted for review? |
the omero-install fixing the version has already been merged. In our doc 1.6 installation will show up instead of 1.4 for ubuntu. |
Looks like we have a mismatch between the versions listed in the 2 tables under https://www.openmicroscopy.org/site/support/omero5.2-staging/sysadmins/version-requirements.html#nginx - first table version 1.0->1.6 and 2nd 1.2->1.9. Looks like we could at least remove 1.0 from the first table and add 1.8 there if not 1.9 as well. |
@aleksandra-tarkowska: could you check the version mismatch? |
Do we really need that table? as @kennethgillen just pointed 1.10 was released, I think they are changing too fast |
I would only keep
or even 1.8+ |
Removing the last table would be out of keeping with the rest of the page, I would just cut it down to show 1.6+. i'd also favour using 1.8+ as the recommended version, we don't want to start referring to 1.10 as recommended when we haven't tested it - we can always update again when 5.3 is closer if we've tested it by then. |
but 1.6+ (1.8+) means 1.10, sorry I am confused now |
please also keep in mind that omero-install install now 1.10 https://travis-ci.org/ome/omero-install/jobs/126070807#L4216 |
Ok, i didn't know that. I would make the last table 1.6, 1.8, 1.9 and 1.10 in that case. And update the table above it as you suggested in your comment before mine. |
1.9 is not what you want as this is develop |
ok, 1.6, 1.8 and 1.10 then |
my point was only that the way we recommend to install nginx in our doc (based on omero-isntall) it will install the latest. This table is out of date once new release comes out If this has to stay I would just make 1 line 1.6+ not 3 for each version |
Ok, do that then. |
@aleksandra-tarkowska 1.6+ is not an appropriate way to represent things for these tables. They document the start and end of life of each upstream release, and our support for each major release and condensing the information in this way would defeat the purpose of having the information in this form to begin with; please do look at the other projects on the page. |
Can we get the information for nginx correct for the 5.2.3 release and then discuss the future of this page via https://trello.com/c/FXt1rXQl/1-scoping-team please? |
Closing in favour of #1460 |
update nginx version requirements
cc @rleigh-dundee
For review: https://www.openmicroscopy.org/site/support/omero5.2-staging/sysadmins/version-requirements.html#nginx