-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add depth option to importer and include ZarrReader #310
Open
dominikl
wants to merge
3
commits into
ome:master
Choose a base branch
from
dominikl:depth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
/* | ||
*------------------------------------------------------------------------------ | ||
* Copyright (C) 2006-2018 University of Dundee. All rights reserved. | ||
* Copyright (C) 2006-2022 University of Dundee. All rights reserved. | ||
* | ||
* | ||
* This program is free software; you can redistribute it and/or modify | ||
|
@@ -190,9 +190,6 @@ public static boolean isArbitraryFile(File f) | |
/** The depth when the name is overridden. */ | ||
private int depthForName; | ||
|
||
/** The depth used when scanning a folder. */ | ||
private int scanningDepth; | ||
|
||
/** | ||
* Flag indicating to override the name set by B-F when importing the data. | ||
*/ | ||
|
@@ -225,6 +222,9 @@ public static boolean isArbitraryFile(File f) | |
/** Map of skip options mapping to ImportConfig functions */ | ||
private Map<String, Object> skipChoices; | ||
|
||
/** The depth Bioformats uses to find the importable files */ | ||
private int depth = Integer.valueOf(System.getProperty("omero.import.depth", "4")); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same |
||
|
||
/** | ||
* Returns the object corresponding to the passed file. | ||
* | ||
|
@@ -355,24 +355,7 @@ public void setMapAnnotation(Map<String,List<MapAnnotationData>> map) | |
{ | ||
this.mapAnnots=getCloneOfMap(map); | ||
} | ||
|
||
|
||
/** | ||
* Sets the depth used scanning a folder. | ||
* | ||
* @param scanningDepth The value to set. | ||
*/ | ||
public void setScanningDepth(int scanningDepth) | ||
{ | ||
this.scanningDepth = scanningDepth; | ||
} | ||
|
||
/** | ||
* Returns the depth used scanning a folder. | ||
* | ||
* @return See above. | ||
*/ | ||
public int getScanningDepth() { return scanningDepth; } | ||
|
||
/** | ||
* Sets the depth used when the name is overridden. | ||
|
@@ -764,4 +747,19 @@ public boolean skipThumbnails() { | |
return option != null && !option; | ||
} | ||
|
||
/** | ||
* Get the depth Bioformats uses to find the importable files | ||
* @return See above | ||
*/ | ||
public int getDepth() { | ||
return depth; | ||
} | ||
|
||
/** | ||
* Set the depth Bioformats uses to find the importable files | ||
* @param depth The depth | ||
*/ | ||
public void setDepth(int depth) { | ||
this.depth = depth; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That property should be put in the config or retrieve from the server if available.