Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep 5.8.4 #416

Merged
merged 11 commits into from
May 13, 2024
Merged

Prep 5.8.4 #416

merged 11 commits into from
May 13, 2024

Conversation

jburel
Copy link
Member

@jburel jburel commented Dec 15, 2023

  • Bump dependencies
  • Add changelog

@jburel jburel requested a review from dominikl December 15, 2023 17:52
@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-insight-push#299. See the console output for more details.
Possible conflicts:

--conflicts

@snoopycrimecop
Copy link
Member

snoopycrimecop commented Dec 17, 2023

Conflicting PR. Removed from build OMERO-insight-push#300. See the console output for more details.
Possible conflicts:

--conflicts Conflict resolved in build OMERO-insight-push#301. See the console output for more details.

@jburel jburel mentioned this pull request Dec 17, 2023
@dominikl
Copy link
Member

Looks good to me. Any idea why the build is failing? Also a bit worried that the merge-ci build doesn't work (strangely local gradle build does).

@jburel jburel closed this Dec 19, 2023
@jburel jburel reopened this Dec 19, 2023
@jburel
Copy link
Member Author

jburel commented Dec 19, 2023

the build was failing because artifacts.openmicroscopy.org was down due to the power outage

@jburel
Copy link
Member Author

jburel commented Jan 3, 2024

Looks good to me. Any idea why the build is failing? Also a bit worried that the merge-ci build doesn't work (strangely local gradle build does).

@dominikl
I have tested locally the following:

  • gradle build
  • unzip build/distributions/OMERO.insight-5.8.4-SNAPSHOT.zip
  • bash OMERO.insight-5.8.4-SNAPSHOT/bin/omero-insight

Everything works as expected.
Then tested the latest release downloaded from GitHub and unzipped i.e.
bash ~/Desktop/OMERO.insight-5.8.3/bin/omero-insight
It works too

@pwalczysko
Copy link
Member

pwalczysko commented Jan 3, 2024

Everything works as expected.
Then tested the latest release downloaded from GitHub and unzipped i.e.
bash ~/Desktop/OMERO.insight-5.8.3/bin/omero-insight
It works too

What @dominikl is meaning is (i.e. grab the build from jenkins, which has to be started using bash as well, but fails as below)

  1. Download https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-insight-build/lastSuccessfulBuild/artifact/build/distributions/OMERO.insight-5.8.4-SNAPSHOT.zip and unzip it
  2. Try to start it and fail with
(cli) pwalczysko@Petrs-MBP ~ % bash ~/Downloads/OMERO.insight-5.8.4-SNAPSHOT/bin/omero-insight
Error: LinkageError occurred while loading main class org.openmicroscopy.shoola.Main
	java.lang.ExceptionInInitializerError: null

@jburel I have successfully repeated your workflow with release artifacts from GitHub - it very much resembles my workflow ^^^ except that the zip is from Jenkins in my case. The only difference thereafter is the result - the Github release artifact just works, the CI artifact from jenkins does not.

@jburel
Copy link
Member Author

jburel commented Jan 3, 2024

It does not work from merge-ci sorry I forgot to mention it in my testing report

@dominikl
Copy link
Member

dominikl commented Jan 3, 2024

👍 Any idea how we could fix the msi installer issue? #400 . I guess that will be bigger effort to find out what's going wrong there, right?

CHANGELOG.md Outdated
@@ -1,3 +1,22 @@
5.8.4 (January 2024)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5.8.4 (January 2024)
5.8.4 (May 2024)

@dominikl
Copy link
Member

dominikl commented May 13, 2024

Looks good. Just release date 'January' should be updated to 'May' :-)

@jburel jburel merged commit 0aa8311 into ome:master May 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants