-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install figure export dependencies by default #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, 👍 for working around errors for the end users, but I worry about the number of places that we have such hard-coded dependencies. I'd really suggest we hammer out "dependency APIs" like pip install omero-figure[server]
that we could re-use everywhere.
@joshmoore I agree about the "dependency APIs". This will need to be prioritised. |
I think in order to solve https://forum.image.sc/t/omere-figure-export-pdf-does-not-work/39573/25, we need this PR.
Edit: The solution is to start the bash for the container already as |
@pwalczysko no longer required to cap reportlab see https://github.com/ome/omero-figure/blob/master/requirements-server.txt |
|
see also ome/ansible-role-postgresql-client#14 (review) perhaps? |
@jburel @joshmoore yes, I can see that the build succeeds on the old mac with the amd achitecture. The error #71 (comment) is only happening on the M1. On the old mac, I am able to run the docker image and connect to the server with insight. Tried to build omero-web in another container and then connect to it, but the omero-web does not see my localhost for some reason. |
Okay, so I have now a test run on my M1 mac:
Works fine. Lgtm. |
Install dependencies required to export figure
Figure might not be installed but this should avoid error like ome/docker-example-omero#11