Swap default min and background thread limits #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkoz
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Looks good to me. I think we need to revisit #159 and have a deeper discussion about whether we want these sorts of requests to block (as they will whenever the Semaphore count is exceeded) or queue up (as they did when min_threads < open requests < background_threads). What we have right now seems to me like an odd mixture of the two.
sbesson
approved these changes
Mar 25, 2024
|
👍 Looks good to me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the background counting semaphore count greater than the minimum thread count (which is actually the maximum) can cause the server to lock up when background tasks consume all these threads. Here we are switching these defaults so that's no longer possible. The only downside to this change is that the background counting semaphore will now be exhausted at 5 tasks rather than 10.
This is an interim solution to #159.