Run setup.py test against entire test folder #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, only the content of test/integration is discovered in the test phase of the Travis CI build for plugins/apps. Discovering other types of tests, typically unit tests, should be harmless. In terms of testing time, migrating testing logic to unit tests rather than integration tests should allow a more thorough coverage while limiting execution time.
|
No objections but perhaps try this PR against https://github.com/ome/omero-plugins to see if anything breaks? |
|
See https://travis-ci.org/ome/omero-plugins/builds/499155148. Two failures:
|
|
Neither seems related to adding more test files though, eh? If that's the case, 👍 |
|
ome/omero-metadata#18 might be a good example of location where additional tests should being executed in Travis once this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, only the content of test/integration is discovered in the test
phase of the Travis CI build for plugins/apps. Discovering other types of
tests, typically unit tests, should be harmless.
In terms of testing time, migrating testing logic to unit tests rather than
integration tests should allow a more thorough coverage while limiting
execution time.