Fix ansible installation and update documentation #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaledk2
requested review from
jburel,
atarkowska and
sbesson
and removed request for
atarkowska
sbesson
reviewed
May 30, 2024
There was a problem hiding this comment.
The doc updates make sense. Outside the scope of this PR, I am not convinced of the benefit of maintaining two nearly identical Ansible playbooks in two separate repositories: here and https://github.com/IDR/deployment
jburel
reviewed
Jul 29, 2024
| mode: 0755 | ||
| with_sequence: start=1 count={{ elasticsearch_no_nodes }} | ||
|
|
||
| - name: Create ELasticsearch backup folder |
There was a problem hiding this comment.
Suggested change
| - name: Create ELasticsearch backup folder | |
| - name: Create elasticsearch backup folder |
| volumes: | ||
| - "{{ apps_folder }}/searchengine/searchengine/:/etc/searchengine/" | ||
|
|
||
| - name: configure IDR_TEST_FILE_URL item |
There was a problem hiding this comment.
This IDR specific so it is something to make more generic
jburel
reviewed
Aug 26, 2024
Co-authored-by: jean-marie burel <[email protected]>
Co-authored-by: jean-marie burel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the searchengine and elasticsearch installation using provided ansible-playbook and updates the installation documentation.