Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update infra #671

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Update infra #671

merged 4 commits into from
Jan 4, 2024

Conversation

jburel
Copy link
Member

@jburel jburel commented Oct 2, 2023 •
edited
Loading

  • Update actions version
  • Replace archived action leading to warning. The current setup will stop working due to the use by the existing action of set-ouput

@jburel jburel requested a review from sbesson October 2, 2023 14:00
sbesson
sbesson approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine to me. I assume the next logical stage is to test the complete deployment workflow and the updated release step

@jburel
Copy link
Member Author

jburel commented Oct 2, 2023

The release part needs to be tested with a release

@jburel
Copy link
Member Author

jburel commented Jan 4, 2024

To be tested with #687

@jburel jburel merged commit 76336a1 into ome:master Jan 4, 2024
2 checks passed
pwalczysko
pwalczysko reviewed Jan 4, 2024
View reviewed changes
.github/workflows/build.yml
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
uses: softprops/action-gh-release@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jburel I believe this is failing at https://github.com/ome/www.openmicroscopy.org/actions/runs/7408919734/job/20158147889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwalczysko pwalczysko pwalczysko left review comments

@sbesson sbesson sbesson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jburel @sbesson @pwalczysko