Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove latest release button #730

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

pwalczysko
Copy link
Member

@pwalczysko pwalczysko commented Jun 3, 2024

As discussed in Slack. The button is hard to update as it requires a manual intervetion.

https://snoopycrimecop.github.io/www.openmicroscopy.org/

cc @dgault @jburel

@will-moore
Copy link
Member

I'm happy for the button to be removed. If we want to keep it, we could call it Latest releases (plural) and link to https://snoopycrimecop.github.io/www.openmicroscopy.org/announcements/ ?

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pwalczysko
Copy link
Member Author

built at snoopy

Do you want to decide @jburel ? If you leave 34c9a87 ub in then the button is not removed but points to Announcements. If you revert 34c9a87, then teh button is removed.

@jburel
Copy link
Member

jburel commented Jun 3, 2024

Latest releases makes sense. It used to be "release" mainly for B-F and openmicroscopy releases but now we have several packages announced via this mechanism

@pwalczysko
Copy link
Member Author

@jburel Thanks, this is what is deployed on snoopy now.

@will-moore could you please have one more look and okay it if appropriate ? Thank you

@pwalczysko
Copy link
Member Author

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Build working fine 👍

@pwalczysko pwalczysko merged commit da05a14 into ome:master Jun 4, 2024
2 checks passed
@pwalczysko pwalczysko deleted the remove-latest-release branch June 4, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants