fix: potential problems that may cause a panic during context setup #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gatici <[email protected]>
|
We are testing this now. |
Signed-off-by: gatici <[email protected]>
Signed-off-by: gatici <[email protected]>
ghislainbourgeois
approved these changes
Dec 6, 2024
gab-arrobo
reviewed
Dec 6, 2024
Signed-off-by: gatici <[email protected]>
Hello @gab-arrobo, Thank you for the review. Your comments are addressed. |
gatici
added a commit
to gatici/amf
that referenced
this pull request
Dec 12, 2024
…mec-project#359) * Fix potential problems that may cause a panic during context setup Signed-off-by: gatici <[email protected]> * improve the logic in HandleRegistrationStatusUpdateRequest Signed-off-by: gatici <[email protected]> * fix linting Signed-off-by: gatici <[email protected]> * Start log messages with lowercase letter Signed-off-by: gatici <[email protected]> --------- Signed-off-by: gatici <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to fix any potential issue that causes: canonical/sdcore-amf-k8s-operator#472
I am not able to reproduce the problem. But, this PR aiming to fix potential issues in the
HandleRegistrationStatusUpdateRequestandContextSetupfunctions.