chore: Adds staticcheck lint check (#55)

omec-project · Jan 4, 2024 · deab294 · deab294
1 parent 6371cd6
commit deab294
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -223,7 +223,7 @@ linters:
     - gofmt
     # - govet
     # - errcheck
-    # - staticcheck
+    - staticcheck
     - unused
     # - gosimple
     # - ineffassign

diff --git a/factory/factory.go b/factory/factory.go
@@ -11,7 +11,7 @@ package factory
 
 import (
 	"fmt"
-	"io/ioutil"
+	"os"
 
 	"gopkg.in/yaml.v2"
 
@@ -22,7 +22,7 @@ var PcfConfig Config
 
 // TODO: Support configuration update from REST api
 func InitConfigFactory(f string) error {
-	if content, err := ioutil.ReadFile(f); err != nil {
+	if content, err := os.ReadFile(f); err != nil {
 		return err
 	} else {
 		PcfConfig = Config{}

diff --git a/producer/smpolicy.go b/producer/smpolicy.go
@@ -130,7 +130,7 @@ func createSMPolicyProcedure(request models.SmPolicyContextData) (
 	sstStr := strconv.Itoa(int(request.SliceInfo.Sst))
 	sliceid := sstStr + request.SliceInfo.Sd
 	self := pcf_context.PCF_Self()
-	imsi := strings.Trim(ue.Supi, "imsi-")
+	imsi := strings.TrimPrefix(ue.Supi, "imsi-")
 	if subsPolicyData, ok := self.PcfSubscriberPolicyData[imsi]; ok {
 		logger.SMpolicylog.Infof("Supi[%s] exist in PcfSubscriberPolicyData", imsi)
 		if PccPolicy, ok1 := subsPolicyData.PccPolicy[sliceid]; ok1 {

diff --git a/service/init.go b/service/init.go
@@ -414,10 +414,16 @@ func (pcf *PCF) UpdateNF() {
 			problemDetails.Status == 404 || problemDetails.Status == 400 {
 			//register with NRF full profile
 			nfProfile, err = pcf.BuildAndSendRegisterNFInstance()
+			if err != nil {
+				initLog.Errorf("PCF register to NRF Error[%s]", err.Error())
+			}
 		}
 	} else if err != nil {
 		initLog.Errorf("PCF update to NRF Error[%s]", err.Error())
 		nfProfile, err = pcf.BuildAndSendRegisterNFInstance()
+		if err != nil {
+			initLog.Errorf("PCF register to NRF Error[%s]", err.Error())
+		}
 	}
 
 	if nfProfile.HeartBeatTimer != 0 {