Refactor path for configuration file, option(s) and Docker image #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arrobo, Gabriel <[email protected]>
…t arguments Signed-off-by: Arrobo, Gabriel <[email protected]>
thakurajayL
reviewed
Nov 1, 2024
| } | ||
| problem := localErr.(openapi.GenericOpenAPIError).Model().(models.ProblemDetails) | ||
| problemDetails = &problem | ||
| } else { | ||
| err = openapi.ReportError("%s: server no response", amfUri) | ||
| } | ||
|
|
||
| defer func() { |
There was a problem hiding this comment.
What benefit we get with this coding style?
There was a problem hiding this comment.
This is to address a linter issue (bodyclose). If you have a better approach, I am more than happy to integrate it into the code.
There was a problem hiding this comment.
why not just close it .. does it give performance benefit of creating new goroutine?
There was a problem hiding this comment.
Do you mean something like this?
defer httpResp.Body.Close()If so, golangci-linter complains with the following error when just using defer httpResp.Body.Close()
consumer/communication.go:56:27: Error return value of `httpResp.Body.Close` is not checked (errcheck)
defer httpResp.Body.Close()
^
thakurajayL
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.