-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves route control script #710
Merged
gab-arrobo
merged 20 commits into
omec-project:master
from
saltiyazan:improves-route-control-script
Oct 19, 2023
Merged
Changes from 9 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
893317b
Initial modifications
saltiyazan 6431fe0
General improvements of route_control.py script
saltiyazan 72cb345
Removes comments
saltiyazan dd0aa92
Adds initial unit tests
saltiyazan 3dfb3ca
Adding more tests
saltiyazan 3dec219
Fixes styling and adds new tests
saltiyazan 9377722
Adds github workflow file
saltiyazan d8c96b7
Addresses review comments
saltiyazan 5092260
Adds new test cases
saltiyazan 1189218
Addresses review comments
saltiyazan f3de54f
Updates unit tests to follow latest changes
saltiyazan 7255b20
Improves logging
saltiyazan f7f2c23
Addresses review comments
saltiyazan fa68856
Adds licensing
saltiyazan bfbc618
Minor fixes
saltiyazan a580b7c
Uses correct path to import and patch route_control
saltiyazan 8b88d00
Addresses review comments
saltiyazan f83da1d
Addresses review comments, fixes tests
saltiyazan fe9dcaf
Merge branch 'master' into improves-route-control-script
gab-arrobo dbbc186
Fixes gate_idx computation when adding a new neighbor
saltiyazan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
name: Python Lint and Test | ||
|
||
on: [push, pull_request] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v2 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: '3.11' | ||
|
||
- name: Create virtual environment | ||
run: python -m venv venv | ||
|
||
- name: Install dependencies | ||
run: ./venv/bin/pip install -r conf/test_requirements.txt | ||
saltiyazan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- name: Run tests | ||
run: ./venv/bin/pytest conf/test_route_control.py | ||
saltiyazan marked this conversation as resolved.
Show resolved
Hide resolved
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not related to this file)
In the PR description, please add context as to why we are making those changes in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.