Feat: Improve supporting LanguageTool local server #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Miura <[email protected]>
- introduce getLanguageModelDefaultPath() Signed-off-by: Hiroshi Miura <[email protected]>
Change to $HOME/.local/share/LanguageTool/ngrams Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
Improve readability with serverCommands private method and startServer private method Signed-off-by: Hiroshi Miura <[email protected]>
and ignore connection errors. Improve readability with serverCommands private method and startServer private method Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
requested review from
Kazephil,
brandelune and
kosivantsov
as code owners
|
No review feedback over 2 weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A code to launch local LanguageTool server from OmegaT has not been maintained in many years.
This improves handling of local LanguageTool server launcher, to add necessary arguments, catch connection error.
Also allow specifying ngram files for LT server.
Pull request type
Which ticket is resolved?
What does this PR change?
--publicto LT server--allow-originto LT server (Handle CORS)\\user\<YourUserName>\AppData\Roaming\languagetool.org\LanguageTool\ngrams$HOME/.local/share/LanguageTool/ngrams/Library/Application-Support/LanguageTool/ngramsOther information