Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix error on Integration Test #1212

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Dec 16, 2024

When changing a way to detect gui environment, the integration test failed to launch.
This PR is to fix the issue.

Pull request type

  • Build and release changes -> [build/release]
    • Fix the weekly release
    • Improve integration test code to debug child process error

What does this PR change?

  • inherit ConsoleWindow to implement TestIntegrationChild.mainWindow
  • TestIntegration: set ProcessBuilder.redirectErrorStream(true)
  • Bump target JDK to 17

Other information

related #1133

@miurahr
Copy link
Member Author

miurahr commented Dec 16, 2024

Now manually launch integration test on Azure pipelines.

@miurahr
Copy link
Member Author

miurahr commented Dec 16, 2024

The integration test has been conducted and passed now.
https://github.com/omegat-org/omegat/pull/1212/checks?check_run_id=34455440451

@miurahr miurahr merged commit 8bcd883 into master Dec 16, 2024
16 checks passed
@miurahr
Copy link
Member Author

miurahr commented Dec 16, 2024

I will run weekly release CI/CD process manually. You will find a new weekly release on source forge soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant