Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preference for paragraph from segmented tmx #1217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Dec 17, 2024

Pull request type

  • Feature enhancement -> [enhancement]

Which ticket is resolved?

What does this PR change?

Other information

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure that preference is very clear to the user.
Screen Shot 2024-12-18 at 13 20 45

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format should be [✓] Verb + information

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kazephil what is your take on this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to explain fully.

  • Show a paragraph as a match result which is constructed from words of segmented matches of segmented internal and external TMXs matched by segmented items of source text on the fuzzy-matches pane on a project configured as no segmentation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about something like this:

Display matches constructed from multiple segments

This option should only be available when the project is in paragraph mode, and there should be a complement in the documentation (as is planned).

What do you think about that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option should only be available when the project is in paragraph mode, and there should be a complement in the documentation (as is planned).

The option is on user option preference, not project preference.

I know. But it is not relevant (and confusing) when the project uses sentence segmentation. OmegaT should be able to detect which options are relevant based on the project preferences.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, is that a feature that applies to the penalty for matches from another language? That's the way it looks like in the screenshot above, but the description in this conversation suggests that it's not related to matches in another language.

No. It is just that the "penalty for other languages" preference should be properly indented to be visually dependent on the relevant checkbox. @miurahr would you mind checking if it is possible to indent the "penalty for other languages" preference?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, the actual indentation gave me the same impression even if I perfectly knew that the option is not related.
Maybe we could increase indentation of options under "Settings for tags"

Copy link
Contributor

@Kazephil Kazephil Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just pushed suggested revisions to the manual updates.

My new best suggestion is simply:
Show matches assembled from multiple segments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, the actual indentation gave me the same impression even if I perfectly knew that the option is not related. Maybe we could increase indentation of options under "Settings for tags"

Or add an extra line above the new option. Or even both! 😁

At the very least, it would certainly look better if the Penalty for matches in other languages phrase at least lined up with the checkboxes for the other options under Settings for tags,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format should be [✓] Verb + information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants