Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1277 wait scripts before compile #1254

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

t-cordonnier
Copy link
Contributor

Pull request type

Bug

Which ticket is resolved?

https://sourceforge.net/p/omegat/bugs/1277/

What does this PR change?

Adds two waiters between the creation of the target files and the associated commit:

  • one for the loop for COMPILE event (all associated handlers must be finished), which runs in the UI thread while compilation is in another thread;
  • one for the scripts associated to COMPILE event, which are lauched by the previously mentioned loop but also run in a separate thread

I also add a last commit which answers to the question which was inserted as TODO, since part of my corrections are in this part.

@t-cordonnier t-cordonnier requested a review from miurahr January 24, 2025 10:40
@@ -116,7 +116,7 @@ public class ScriptingWindow {

private static final Logger LOGGER = Logger.getLogger(ScriptingWindow.class.getName());

static ScriptingWindow window;
static public ScriptingWindow window;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here declares static public

@@ -111,9 +111,12 @@ public static void registerEditorEventListener(final IEditorEventListener listen
public static void unregisterEditorEventListener(final IEditorEventListener listener) {
EDITOR_EVENT_LISTENERS.remove(listener);
}

public static boolean isInProjectEventLoop = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This defines public static

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants