Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE#1725] feat: UserPassDialog extra space char #803

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Nov 16, 2023

Many translators may paste password with training space character that lead authentication error.
The enhance here to check whether password text has extra space, show warning and disable OK button.

Pull request type

  • Feature enhancement -> [enhancement]

Which ticket is resolved?

What does this PR change?

  • Check validity of username and password
  • When there is extra space character, warn it
  • Don't manipulate username or password text in application to keep privacy habit

Other information

- Check validity of username and password
- When there is extra space character, warn it

Signed-off-by: Hiroshi Miura <[email protected]>
@brandelune
Copy link
Contributor

Although an automatic check is nice, what would be better is that the password is displayed in the field so that users can check what they pasted right away.

Using black dots for the password field makes no security sense at all and keeps users from checking what they type/paste.

@miurahr
Copy link
Member Author

miurahr commented Nov 16, 2023

Although an automatic check is nice, what would be better is that the password is displayed in the field so that users can check what they pasted right away.

Using black dots for the password field makes no security sense at all and keeps users from checking what they type/paste.

see Oracle genuine Java manual https://docs.oracle.com/javase/tutorial/uiswing/components/passwordfield.html

Signed-off-by: Hiroshi Miura <[email protected]>
@brandelune
Copy link
Contributor

Although an automatic check is nice, what would be better is that the password is displayed in the field so that users can check what they pasted right away.
Using black dots for the password field makes no security sense at all and keeps users from checking what they type/paste.

see Oracle genuine Java manual https://docs.oracle.com/javase/tutorial/uiswing/components/passwordfield.html

"For security reasons, a password field does not show the characters that the user types. Instead, the field displays a character different from the one typed, such as an asterisk '*'."

-> That makes no security sense. Especially in a copy/paste context on a personal computer.

"As another security precaution, a password field stores its value as an array of characters, rather than as a string."

I understand that you might not want to reimplement that.

@miurahr
Copy link
Member Author

miurahr commented Nov 16, 2023

Implemented show/hide button

@miurahr
Copy link
Member Author

miurahr commented Nov 19, 2023

Now all the feedback from reviewer are adjusted.

@miurahr miurahr merged commit 6910732 into master Nov 20, 2023
8 checks passed
@miurahr miurahr deleted the topic/miurahr/team/password-field-trim-space branch November 20, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants