-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFE#1725] feat: UserPassDialog extra space char #803
Conversation
- Check validity of username and password - When there is extra space character, warn it Signed-off-by: Hiroshi Miura <[email protected]>
Although an automatic check is nice, what would be better is that the password is displayed in the field so that users can check what they pasted right away. Using black dots for the password field makes no security sense at all and keeps users from checking what they type/paste. |
see Oracle genuine Java manual https://docs.oracle.com/javase/tutorial/uiswing/components/passwordfield.html |
Signed-off-by: Hiroshi Miura <[email protected]>
"For security reasons, a password field does not show the characters that the user types. Instead, the field displays a character different from the one typed, such as an asterisk '*'." -> That makes no security sense. Especially in a copy/paste context on a personal computer. "As another security precaution, a password field stores its value as an array of characters, rather than as a string." I understand that you might not want to reimplement that. |
Signed-off-by: Hiroshi Miura <[email protected]>
Implemented show/hide button |
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
Now all the feedback from reviewer are adjusted. |
Many translators may paste password with training space character that lead authentication error.
The enhance here to check whether password text has extra space, show warning and disable OK button.
Pull request type
Which ticket is resolved?
https://sourceforge.net/p/omegat/feature-requests/1725/
What does this PR change?
Other information