Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mac distributions: allow JRE other than java 11 #807

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Nov 18, 2023

Refactor a build mac distribution section of buid.gradle .
Drop mac and armMac definition of distributions section.
This make simpler distributions definition.

Pull request type

  • Bugs
  • Build and release changes

Which ticket is resolved?

What does this PR change?

  • Tasks to generate mac distributions are defined as same way as Windows tasks.
  • Change plist.info to be accept JVM 11+
  • Build appbundler with jvmrequired: ${jvmrequired} other than direct value, and substitute it in pacakging.

Other information

@miurahr miurahr force-pushed the topic/miurahr/build/refacotr-mac-distributions branch from 6df1975 to ca733c9 Compare November 18, 2023 07:36
@miurahr miurahr marked this pull request as ready for review November 18, 2023 07:39
@miurahr miurahr changed the title chore: refactor build.gradle for mac distributions chore: mac distributions: allow JRE other than java 11 Nov 18, 2023
@miurahr miurahr added the bug label Nov 18, 2023
@miurahr miurahr merged commit d30f940 into master Nov 18, 2023
8 checks passed
@miurahr miurahr deleted the topic/miurahr/build/refacotr-mac-distributions branch November 18, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant