Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide alt text configuration options for images. #1037

Merged
merged 11 commits into from
Sep 30, 2024

Conversation

kimisgold
Copy link
Member

  • Within the Appearance Settings, users can select an element that can provide alt text for files.
  • Users can also write alt text via a new field on the file edit form. This field will override alt text provided by file metadata.
  • Images use a blank alt by default.
  • File markup no longer provides titles by default, nor populate titles using the alt attribute.
  • Browse views no longer assign "presentation" roles to the record images.

* Within the Appearance Settings, users can select an element that can provide alt text for files.
* Users can also write alt text via a new field on the file edit form. This field will override alt text provided by file metadata.
* Images use a blank alt by default.
* File markup no longer provides titles by default, nor populate titles using the alt attribute.
* Browse views no longer assign "presentation" roles to the record images.
Copy link
Member

@zerocrates zerocrates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.

My most substantive comments relate to the fallback to an element and will be found on the settings and in the File model.

application/forms/AppearanceSettings.php Outdated Show resolved Hide resolved
admin/themes/default/items/browse.php Outdated Show resolved Hide resolved
admin/themes/default/files/show.php Outdated Show resolved Hide resolved
application/models/File.php Show resolved Hide resolved
application/models/File.php Outdated Show resolved Hide resolved
admin/themes/default/files/edit.php Outdated Show resolved Hide resolved
application/forms/AppearanceSettings.php Outdated Show resolved Hide resolved
application/migrations/20240917160000_addFileAltText.php Outdated Show resolved Hide resolved
application/models/File.php Outdated Show resolved Hide resolved
@zerocrates zerocrates merged commit 9eae3e2 into master Sep 30, 2024
10 checks passed
@zerocrates zerocrates deleted the file-alt-text-options branch September 30, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants