Fixed rendering of oembed with html.

omeka · Oct 28, 2018 · a4aebe6 · a4aebe6
1 parent b8c2631
commit a4aebe6
Showing 1 changed file with 4 additions and 13 deletions.
diff --git a/application/src/Media/Renderer/OEmbed.php b/application/src/Media/Renderer/OEmbed.php
@@ -15,11 +15,7 @@ public function render(PhpRenderer $view, MediaRepresentation $media,
             $url = $data['url'];
             $width = $data['width'];
             $height = $data['height'];
-            if (!empty($data['title'])) {
-                $title = $data['title'];
-            } else {
-                $title = $url;
-            }
+            $title = empty($data['title']) ? $url : $data['title'];
             return sprintf(
                 '<img src="%s" width="%s" height="%s" alt="%s">',
                 $view->escapeHtml($url),
@@ -29,14 +25,9 @@ public function render(PhpRenderer $view, MediaRepresentation $media,
             );
         } elseif (!empty($data['html'])) {
             return $data['html'];
-        } else {
-            $source = $media->source();
-            if (!$empty($data['title'])) {
-                $title = $data['title'];
-            } else {
-                $title = $source;
-            }
-            return $view->hyperlink($title, $source);
         }
+        $source = $media->source();
+        $title = empty($data['title']) ? $source : $data['title'];
+        return $view->hyperlink($title, $source);
     }
 }