-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a button to link to the public page of a resource. #1259
Open
Daniel-KM
wants to merge
4
commits into
omeka:develop
Choose a base branch
from
Daniel-KM:feature/button_public_view
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1108 is merged so if you've been waiting for us to merge to file the "reverse direction" PR as this one, go ahead. I think we'd prefer that as a separate PR. |
Daniel-KM
force-pushed
the
feature/button_public_view
branch
from
August 13, 2018 09:08
10e2d4c
to
4ce8388
Compare
Daniel-KM
force-pushed
the
feature/button_public_view
branch
from
August 27, 2018 11:41
4ce8388
to
0677ddf
Compare
Rebased. |
Daniel-KM
force-pushed
the
feature/button_public_view
branch
from
December 17, 2018 14:11
0677ddf
to
a87d7f4
Compare
Daniel-KM
added a commit
to Daniel-KM/Omeka-S-module-Next
that referenced
this pull request
Dec 17, 2018
Rebased on 1.3. Available via module Next. |
Daniel-KM
added a commit
to Daniel-KM/Omeka-S-module-Next
that referenced
this pull request
Dec 18, 2018
Daniel-KM
force-pushed
the
feature/button_public_view
branch
from
April 15, 2019 04:38
a87d7f4
to
5668d59
Compare
Rebased on 1.4. Available via module Next. |
Daniel-KM
force-pushed
the
feature/button_public_view
branch
from
October 28, 2019 22:42
5668d59
to
920dbfa
Compare
Merged with laminas. |
Daniel-KM
force-pushed
the
feature/button_public_view
branch
from
January 6, 2022 12:19
6d8b904
to
428343d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like in Omeka Classic, add a button to link to the public page of an item / item set / media. This is the link to the default site. Ideally, a setting should be added to allow each user to select a default site. This link can be added in other pages too (action list in browse pages or in details). Instead of a view helper, the feature can be added as a method of ResourceRepresentation too, or another argument to url().
The reverted feature is ready (link to the admin page from the user bar), but requires the #1108 .