Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genericized batch actions js for browse pages. #1260

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Daniel-KM
Copy link
Contributor

@Daniel-KM Daniel-KM commented May 22, 2018

I have new modules to export selected resources (for example Zotero and ods), so it is simpler to manage when the batch actions in admin.js is genericized.

@Daniel-KM Daniel-KM force-pushed the feature/batch_actions_js branch from d397a70 to 1ffb0ec Compare May 23, 2018 05:43
@zerocrates
Copy link
Member

data-select="selected" here just refers to options that should be disabled when there are no selections and enabled when there are? For something that's just on/off like that I'd go for a class rather than a data attribute.

We really also should be using the HTML5 "bare" form for disabled and prop rather than attr in the JS, but those are preexisting problems there.

@Daniel-KM
Copy link
Contributor Author

I set a class instead of a data.

@Daniel-KM Daniel-KM force-pushed the feature/batch_actions_js branch from 74d1dc7 to f8e728c Compare August 13, 2018 09:09
@Daniel-KM Daniel-KM force-pushed the feature/batch_actions_js branch from f8e728c to 2de0964 Compare August 27, 2018 11:44
@Daniel-KM
Copy link
Contributor Author

Rebased.

@Daniel-KM
Copy link
Contributor Author

Fixed disabled, not the js.

@Daniel-KM Daniel-KM force-pushed the feature/batch_actions_js branch from 2de0964 to f92650b Compare December 17, 2018 14:20
@Daniel-KM
Copy link
Contributor Author

Rebased on 1.3.

Daniel-KM added a commit to Daniel-KM/Omeka-S-module-ZoteroImport that referenced this pull request Apr 15, 2019
Daniel-KM added a commit to Daniel-KM/Omeka-S-module-Ebook that referenced this pull request Apr 15, 2019
Daniel-KM added a commit to Daniel-KM/Omeka-S-module-Correction that referenced this pull request Apr 15, 2019
@Daniel-KM Daniel-KM force-pushed the feature/batch_actions_js branch from f92650b to eac2e70 Compare April 15, 2019 04:41
@Daniel-KM
Copy link
Contributor Author

Rebased on 1.4.

Daniel-KM added a commit to Daniel-KM/Omeka-S-module-Ebook that referenced this pull request Jul 10, 2019
@Daniel-KM Daniel-KM force-pushed the feature/batch_actions_js branch from eac2e70 to e9cfefa Compare October 28, 2019 22:42
@Daniel-KM
Copy link
Contributor Author

Merged for laminas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants