-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a way to use psr-3 messages. #1372
base: develop
Are you sure you want to change the base?
Conversation
What kinds of situations are you envisioning where you might use this new message class outside the messenger or the logger? I'd really prefer to see it use the same code path as is currently used in the messenger for translating the sprintf-based messages... in other words I'd be happier with something that altered the existing Message and created an interface the two message types would share (something like |
The main usage is messenger and logger. I don't have any other usage currently. |
ef8610b
to
f6f0d65
Compare
In fact, there is another usage: to write e-mails (config form of module GuestUser), where string placeholders are simpler to use by end users. |
f6f0d65
to
ee12339
Compare
Rebased on 1.4. |
ee12339
to
4fa71e2
Compare
Rebased on 2.0. |
Merged for laminas. |
Merged with upstream/develop. |
ecba1ae
to
171e3dc
Compare
Allows to use psr-3 compliant messages : https://www.php-fig.org/psr/psr-3
When accepted, another pr will allow to use psr strings in logs.
Fixes #1183