Allowed to remove a user when there are api keys. #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We already have the Doctrine-level "cascade=remove" on the other end of this relationship which should be handling this. Anecdotally, I don't have any issue deleting users that have API keys. Are you encountering that as a problem? |
|
It allows direct sql queries too. I have a site with more than 30000 guest users, and each year, many students are removed. |
|
Rebased on develop. |
Resource values improvements
All the overrides are already public and things are assuming that the method just generally is public.
Before we just checked if the object's class name was in an array of valid class names. This does not work when the object is a Doctrine proxy. To fix this, we check if the object is an instanceof one of the valid class names.
Update Font Awesome library to version 5.15.4.
Check instanceof when validating value resource
Makes "required" fields more robust, and fixes usage of elements that Laminas defaults as required (here we're defaulting to not-required). (fix omeka#1779)
The page title for sites was hardcoded to H2. Now one can change it to suite their needs.
Title is passed unescaped. Escaping takes place in the view.
Addd block layout template for page title
Allow theme config to set server-side required
* Remove references to unused regular and brands fonts. * Rename fontawesome sass files so they do not generate css. * Default to 900 font weight.
Daniel-KM
force-pushed
the
fix/user_api_key
branch
from
302c095 to
2552dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.