Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update components from latest shadcn updates. #50

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

Mr-Vipi
Copy link
Contributor

@Mr-Vipi Mr-Vipi commented Nov 9, 2024

update the phone input component and its corresponding dependency components as this last commit from shadcn

#shadcn-ui/ui@4a0d4cf

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-phone-input ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:17pm

Copy link
Owner

@omeralpi omeralpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the components were updated but formatting is missing.
Please make sure to run pnpm format:write to format the code.

Additionally, I’ve created an issue #51 for integrating Husky, which should help enforce formatting. Let me know if you’d like me to assign it to you.

@@ -100,7 +100,7 @@ const CountrySelect = ({
<Button
type="button"
variant={"outline"}
className={cn("flex gap-1 rounded-e-none rounded-s-lg px-3")}
className={cn("flex gap-1 rounded-e-none rounded-s-lg px-3 [&_svg]:h-4 [&_svg]:w-6")}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[&_svg]:h-4 [&_svg]:w-6 overrides ChevronUpDown's h-4 w-4. Consider removing or adjusting to avoid conflicts!
If this PR focuses on components/ui (shadcn), please keep changes within scope. Otherwise, consider a separate PR!

Thanks ♥

@@ -129,7 +129,7 @@ const CountrySelect = ({
.filter((x) => x.value)
.map((option) => (
<CommandItem
className="gap-2"
className="[&_svg]:h-4 [&_svg]:w-6"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[&_svg]:h-4 [&_svg]:w-6 overrides CheckIcon's h-4 w-4. Consider removing or adjusting to avoid conflicts!
If this PR focuses on components/ui (shadcn), please keep changes within scope. Otherwise, consider a separate PR!

Thanks ♥

@omeralpi omeralpi merged commit 7f7c092 into omeralpi:main Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants