-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update components from latest shadcn updates. #50
Conversation
update input component as latest input from shadcn
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the components were updated but formatting is missing.
Please make sure to run pnpm format:write
to format the code.
Additionally, I’ve created an issue #51 for integrating Husky, which should help enforce formatting. Let me know if you’d like me to assign it to you.
components/ui/phone-input.tsx
Outdated
@@ -100,7 +100,7 @@ const CountrySelect = ({ | |||
<Button | |||
type="button" | |||
variant={"outline"} | |||
className={cn("flex gap-1 rounded-e-none rounded-s-lg px-3")} | |||
className={cn("flex gap-1 rounded-e-none rounded-s-lg px-3 [&_svg]:h-4 [&_svg]:w-6")} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[&_svg]:h-4 [&_svg]:w-6
overrides ChevronUpDown
's h-4 w-4
. Consider removing or adjusting to avoid conflicts!
If this PR focuses on components/ui (shadcn), please keep changes within scope. Otherwise, consider a separate PR!
Thanks ♥
content/snippets/phone-input.mdx
Outdated
@@ -129,7 +129,7 @@ const CountrySelect = ({ | |||
.filter((x) => x.value) | |||
.map((option) => ( | |||
<CommandItem | |||
className="gap-2" | |||
className="[&_svg]:h-4 [&_svg]:w-6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[&_svg]:h-4 [&_svg]:w-6
overrides CheckIcon
's h-4 w-4
. Consider removing or adjusting to avoid conflicts!
If this PR focuses on components/ui (shadcn), please keep changes within scope. Otherwise, consider a separate PR!
Thanks ♥
eda6b25
to
bf4ec55
Compare
update the phone input component and its corresponding dependency components as this last commit from shadcn
#shadcn-ui/ui@4a0d4cf