Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log exceptions that happen when reporting metrics #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pyformance/reporters/reporter.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
import logging
import time
from threading import Thread, Event
import six
from ..registry import global_registry, get_qualname


LOG = logging.getLogger(__name__)

class Reporter(object):
def create_thread(self):
# noinspection PyAttributeOutsideInit
Expand Down Expand Up @@ -43,7 +46,8 @@ def _loop(self):
while not self._stopped.is_set():
try:
self.report_now(self.registry)
except:
except Exception as e:
LOG.error("Exception caught while reporting metrics", exc_info=e)
pass
next_loop_time += self.reporting_interval
wait = max(0, next_loop_time - time.time())
Expand Down