Issue #32280/ bug fix: WHERE segment with ON CONFLICT segment in INSERT throws exception #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ement of postgres
Fixes apache#32280
Changes proposed in this pull request:
whereSegment
inonConflictKeyColumnSegment
which was missing and required. The current flow is more intent on theon_duplicate
of MySQL thanon_conflict
in Postgres which has been added in Postgres after Postgres 9.optOnConflict
rule which was eventually failing to read parameter markers expressions and assignments present inwhereSegment
INSERT INTO
statement. The flow for ON DUPLICATE has not been removed or altered for now, as It may be useful for certain conditions of older versions of Postgres (and can be deprecated in future if no use case is observed for long)Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.