Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 65 byte uncompressed key in Staking.sol #2773

Open
kevinhalliday opened this issue Jan 10, 2025 · 0 comments
Open

Use 65 byte uncompressed key in Staking.sol #2773

kevinhalliday opened this issue Jan 10, 2025 · 0 comments
Milestone
c1.2 - Permission...

Comments

@kevinhalliday
Copy link
Contributor

kevinhalliday commented Jan 10, 2025 •
edited
Loading

Problem to Solve

Currently createValidator takes x,y coords. This is not standard. We should take a single uncompressed 65 byte key, which is standard.

Proposed Solution

Update createValidator to take single 65 byte uncompressed key.

Upgrading this change to omega / mainnet can be done alongside other staking changes.
@kevinhalliday kevinhalliday mentioned this issue Jan 10, 2025
Merged
kevinhalliday added a commit that referenced this issue Jan 13, 2025
@kevinhalliday
fix(contracts/core): include msg sender in createValidator digest (#2779
6505eca 
)

Include msg.sender in digest to be signed by cons pub key 
passed in createValidator(). This prevents front running createValidator
transactions.

This is not an active issue, as we have an allowlist of validators. But
will be important when that allowlist is disabled.

Additional:
- refactor to use 33 byte compressed pubkey, instead of x y coords
- cleanup
- add back tests for createValidator w/o signature

issue: #2773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
c1.2 - Permissionless Staking [Q1 2025]
Development

No branches or pull requests
1 participant
@kevinhalliday