fix(contracts/core): include msg sender in createValidator digest #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhalliday
requested review from
corverroos,
chmllr,
kc1116 and
Zodomo
as code owners
kevinhalliday
force-pushed
the
kh/staking-fixes
branch
from
3d2fe52 to
d1d8370
Compare
corverroos
approved these changes
Jan 13, 2025
kevinhalliday
force-pushed
the
kh/staking-fixes
branch
from
d1d8370 to
a98e06d
Compare
Additional: - refactor to use 33 byte compressed pubkey, instead of x y coords
kevinhalliday
force-pushed
the
kh/staking-fixes
branch
from
a98e06d to
4253435
Compare
kevinhalliday
added a commit
that referenced
this pull request
Jan 28, 2025
Update eip712 typehash to match digest. We changed digest in #2779 but did not update typehash. Not a real issue, but good to be correct. issue: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include msg.sender in digest to be signed by cons pub key
passed in createValidator(). This prevents front running createValidator transactions.
This is not an active issue, as we have an allowlist of validators. But will be important when that allowlist is disabled.
Additional:
issue: #2773