Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wishlist] merge changes from gitlab_omniauth-ldap #82

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

pravi
Copy link

@pravi pravi commented Mar 17, 2018

gitlab_omniauth-ldap was created as a fork when omniauth-ldap was inactive. Now that omniauth-ldap is active again, it makes sense to integrate their changes back into omniauth-ldap and combine efforts. It would be a good idea to give some of them commit access here.

Dmitriy Zaporozhets and others added 25 commits June 26, 2012 10:51
If no username or password is provided a MissingCredentialsError is
raised which causes a Rack caught exception and a 500 Error in gitlab.
Omniauth provides a way to raise such errors to the application by
using the 'fail!' method to pass the exception to the registered
failure handler. For gitlab this is the omniauth_controller code.

This is required to resolve gitlab issue #1077.

Signed-off-by: Pat Thoyts <[email protected]>
Report missing credentials to the Rails application.
Newer LDAP servers fail with older versions of net-ldap.
Update to the fixed version.

Signed-off-by: David Aguilar <[email protected]>
Gemfile.lock: update net-ldap to fix LDAP authentication issues
Update version to match intridea/omniauth-ldap.
Add test for alternate fields.
net-ldap version update

There is a bug in net-ldap < 0.5.0 preventing connections to Microsoft servers. Pushing the net-ldap dependency version should fix it. See the following net-ldap issue for a description.

ruby-ldap/ruby-net-ldap#80

See merge request !2
Considering we are bumping net-ldap from 0.3.1 to 0.7.0 I thought a
minor version bump might be called for.
Signed-off-by: Dmitriy Zaporozhets <[email protected]>
Bump net ldap

Related to gitlab/gitlabhq#1700

See merge request !1
Signed-off-by: Dmitriy Zaporozhets <[email protected]>
@MrBerg
Copy link

MrBerg commented Oct 11, 2018

At least the changes for lib/omniauth/strategies/ldap.rb and spec/omniauth/strategies/ldap_spec.rb seem very useful.

@MrBerg
Copy link

MrBerg commented Oct 12, 2018

It seems like GitLab.org development of the fork has moved to https://gitlab.com/gitlab-org/omniauth-ldap since.

@pravi
Copy link
Author

pravi commented Oct 12, 2018

@MrBerg you can see this discussion with maintainers of the fork here https://gitlab.com/gitlab-org/gitlab-ce/issues/13280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants