Skip to content

Public Queries #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Public Queries #47

wants to merge 21 commits into from

Conversation

hobbescodes
Copy link
Contributor

@hobbescodes hobbescodes commented May 1, 2025

Description

Task link: https://linear.app/omnidev/issue/OMNI-340/unauth-users-should-be-able-to-see-projects

This PR refactors limitations on the API to allow for queries to be consumed by unauthorized users. The biggest change this PR implements is removing the need for validation against an accessToken derived from the Authorization header.

Test Steps

  1. Verify that logic is sound
  2. Validate that queries work appropriately for unauthorized users
  3. Validate that ALL mutations are still restricted as expected

@hobbescodes hobbescodes changed the base branch from master to feature/prerelease May 1, 2025 03:23
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont know if we really need to ever throw here anymore, but rather just early return null. The null will be used for the RBAC plugins and be caught to protect the mutations.

Base automatically changed from feature/prerelease to master May 2, 2025 17:13
@hobbescodes hobbescodes marked this pull request as ready for review May 15, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants