Test suite #51
Merged
Test suite #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hobbescodes
reviewed
Jan 10, 2025
hobbescodes
reviewed
Jan 10, 2025
| "plugins": [ | ||
| { | ||
| "name": "next" | ||
| } | ||
| ], | ||
| "baseUrl": "src" | ||
| "types": ["bun"] |
There was a problem hiding this comment.
Ohhh does this work for all DefinitelyTyped packages? If so that is cool. I have always added @types/bun, etc here haha
There was a problem hiding this comment.
Honestly I'm not sure if it applies to all cases of DT (or bundled/non-DT) packages, but nice lil shortcut for several that I've tried
Twonarly1
reviewed
Jan 16, 2025
Co-authored-by: Beau Hawkinson <[email protected]>
benjamin-parks
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task link: https://linear.app/omnidev/issue/OMNI-87/integrate-playwright-msw-for-e2e-testing, https://linear.app/omnidev/issue/OMNI-151/set-up-unit-test-framework-bun-vanilla-if-possible
Note
This PR is not intended to provide robust coverage over our existing codebase, rather to get the foundation started and merged in so we can agree on a clean config and then build out tests (including more fixtures, mocks, etc.) as a team later. Further, there are lots of TODOs introduced in this PR, but they are all incredibly related, mostly via pending app router support.
Warning
MSW does not currently fully support the Next.js app router, so E2E tests are skipped for now as a consequence. Track mswjs/examples#101. Once this is merged, it can be used as an integration reference, and the tests can be enabled.
Test Steps
Before testing the tests by testing them in a testful fashion, make sure to set the new environment variables (both adding the new ones and setting up
.env.test.local).One specific question: is uploading E2E test artifacts useful in the first place? We could simplify the workflow and speed up execution time by skipping it. In the future, we will likely have a more robust CI integration with artifact uploads. This question is connected to the disabledDecision: scrapmerge_e2e_reportsjob + corresponding TODOAnother question: instead ofDecision: consolidate.env.test.local, it might be desirable to just load the local.env.localif running E2E tests locally. Let me know thoughts on this! Had some annoyances getting it working but it might be nice, I'm not sure about long-term benefits leaning into the decision for either approachbun run test(note that some are skipped, see colocated code for details)bun test:e2e(note that these tests are skipped, see warning above; just make sure the command works)