Avoid overriding of Event::$omitErrors value while running commands #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize AbstractEvent::filtersPass() checking rejects first
Refactor an event dispatching and running of callbacks Set lock only before running command (not during configuration) Do not return CallbackEvent result but set into the property Finish only one matching scheduled job per callback run
Output message if no jobs ran Finish only ShellJobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiy guys.
First of all, thank you for the extension.
I tried to use the ext in my application but found out that any
Event::$omitErrorsvalue set in a config is overridden in the controller while running. Thus, it does not matter which value we set configuring the schedule before, it will be overridden.The default value of
Event::$omitErrorsisfalse, so we don't need to overwrite it in the controller.I understand that sometimes it could be useful to globally force omitting (or not) errors. In this case I agree, we can use a controller property, but mb give it more obvious name (forceOmitErrors, globalOmitErrors, etc.)?)
My changes in general don't break BC and only allow us to configure
omitErrorsparam for each command (Event) independently in a config.