-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set flag readonly
recursively
#1124
Open
MatteoVoges
wants to merge
5
commits into
omry:master
Choose a base branch
from
neXenio:feat/set-flag-recursively
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@odelalleau with this I get: from omegaconf import OmegaConf
config = OmegaConf.create({"a": {"b": 1}})
OmegaConf.set_readonly(config.a, True)
OmegaConf.set_readonly_recursively(config, False)
print(OmegaConf.is_readonly(config.a))
# >>> False |
MatteoVoges
changed the title
feat: set flag readonly recursively
feat: set flag Sep 20, 2023
readonly
recursively
Thanks! I would suggest to do it a bit differently to have a more generic implementation:
|
Thanks for the update -- overall looks good to me, but I won't have time to look at it in details until next week. We'll need to add a news fragment as well and update the documentation. |
MatteoVoges
force-pushed
the
feat/set-flag-recursively
branch
from
September 26, 2023 09:05
a4995a7
to
c64a9db
Compare
@omry @odelalleau this is a blocker for #1102, would be great to get it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I want a function that sets a value for a flag (atm
readonly
, but can be extended for all / generic flags) recursively.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Tests will be added if the basic structure is confirmed.
Fixes
Fixes #1123