-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CSafeLoader when possible #1150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good but can you please add a news fragment about this change?
Done, let me know if that looks good to you! By the way, it might be worth adding something about news fragments in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good with this minor change
Good point, see #1151 (unfortunately I can't add you as reviewer) |
Co-authored-by: Olivier Delalleau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Motivation
yaml.CSafeLoader
is significantly faster. However, it is not always available. The proposed change is to use it whenever it is available with a fall back toyaml.SafeLoader
(current loader).Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
No additional tests required, current tests should cover yaml being parsed correctly.
Fixes
What issue does this PR fix? Use https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue to link this PR to a corresponding issue.
Fixes #1149
Related PRs