Change deepcopy logic to be constrained on correct type #1199
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deep copy is always done when it is done with an instance of Box and the roots are the same. Box doesn't contain get_root so this condition fails causes an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deep copy is always done when it is done with an instance of Box and the roots are the same. Box doesn't contain get_root so this condition fails causes an error.
Motivation
Broken Case
Have you read the Contributing Guidelines on pull requests?
Yes/No
Test Plan
This issue is showing up in an internal Meta codebase
Fixes
No Issue
Related PRs
None